Skip to content

Port TypeScript PR #62320: Allow --module commonjs --moduleResolution bundler #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −56
Draft

Port TypeScript PR #62320: Allow --module commonjs --moduleResolution bundler #2757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5155abd
Initial plan
Copilot Feb 11, 2026
b92e727
Port TypeScript PR #62320: Allow --module commonjs --moduleResolution…
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions internal/compiler/program.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,10 +925,9 @@ func (p *Program) verifyCompilerOptions() {
createDiagnosticForOptionName(diagnostics.Option_0_can_only_be_used_when_moduleResolution_is_set_to_node16_nodenext_or_bundler, "customConditions", "")
}

// !!! Reenable once we don't map old moduleResolution kinds to bundler.
// if moduleResolution == core.ModuleResolutionKindBundler && !emitModuleKindIsNonNodeESM(moduleKind) && moduleKind != core.ModuleKindPreserve {
// createOptionValueDiagnostic("moduleResolution", diagnostics.Option_0_can_only_be_used_when_module_is_set_to_preserve_or_to_es2015_or_later, "bundler")
// }
if moduleResolution == core.ModuleResolutionKindBundler && !emitModuleKindIsNonNodeESM(moduleKind) && moduleKind != core.ModuleKindPreserve && moduleKind != core.ModuleKindCommonJS {
createOptionValueDiagnostic("moduleResolution", diagnostics.Option_0_can_only_be_used_when_module_is_set_to_preserve_commonjs_or_es2015_or_later, "bundler")
}

if core.ModuleKindNode16 <= moduleKind && moduleKind <= core.ModuleKindNodeNext &&
!(core.ModuleResolutionKindNode16 <= moduleResolution && moduleResolution <= core.ModuleResolutionKindNodeNext) {
Expand Down
2 changes: 2 additions & 0 deletions ...ule/conformance/bundlerDirectoryModule(module=node18,moduleresolution=bundler).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
error TS5109: Option 'moduleResolution' must be set to 'Node16' (or left unspecified) when option 'module' is set to 'Node18'.


!!! error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
!!! error TS5109: Option 'moduleResolution' must be set to 'Node16' (or left unspecified) when option 'module' is set to 'Node18'.
==== /app/test.ts (0 errors) ====
import { test } from '../lib';
Expand Down
11 changes: 0 additions & 11 deletions ...onformance/bundlerDirectoryModule(module=node18,moduleresolution=bundler).errors.txt.diff
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions ...ule/conformance/bundlerDirectoryModule(module=node20,moduleresolution=bundler).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
error TS5109: Option 'moduleResolution' must be set to 'Node16' (or left unspecified) when option 'module' is set to 'Node20'.


!!! error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
!!! error TS5109: Option 'moduleResolution' must be set to 'Node16' (or left unspecified) when option 'module' is set to 'Node20'.
==== /app/test.ts (0 errors) ====
import { test } from '../lib';
Expand Down
11 changes: 0 additions & 11 deletions ...onformance/bundlerDirectoryModule(module=node20,moduleresolution=bundler).errors.txt.diff
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions ...e/conformance/bundlerDirectoryModule(module=nodenext,moduleresolution=bundler).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
error TS5109: Option 'moduleResolution' must be set to 'NodeNext' (or left unspecified) when option 'module' is set to 'NodeNext'.


!!! error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
!!! error TS5109: Option 'moduleResolution' must be set to 'NodeNext' (or left unspecified) when option 'module' is set to 'NodeNext'.
==== /app/test.ts (0 errors) ====
import { test } from '../lib';
Expand Down
11 changes: 0 additions & 11 deletions ...formance/bundlerDirectoryModule(module=nodenext,moduleresolution=bundler).errors.txt.diff
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion testdata/baselines/reference/submodule/conformance/bundlerOptionsCompat.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
/tsconfig.json(4,25): error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
/tsconfig.json(4,25): error TS5109: Option 'moduleResolution' must be set to 'NodeNext' (or left unspecified) when option 'module' is set to 'NodeNext'.


==== /tsconfig.json (1 errors) ====
==== /tsconfig.json (2 errors) ====
{
"compilerOptions": {
"module": "nodenext",
"moduleResolution": "bundler",
~~~~~~~~~
!!! error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve', 'commonjs', or 'es2015' or later.
~~~~~~~~~
!!! error TS5109: Option 'moduleResolution' must be set to 'NodeNext' (or left unspecified) when option 'module' is set to 'NodeNext'.
"noEmit": true
}
Expand Down
18 changes: 0 additions & 18 deletions testdata/baselines/reference/submodule/conformance/bundlerOptionsCompat.errors.txt.diff
View file
Open in desktop

This file was deleted.