Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TerminalOutputDevice ITestApplicationCancellationTokenSource f… #4893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

remove TerminalOutputDevice ITestApplicationCancellationTokenSource f… #4893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@
}

public static TerminalOutputDevice GetDefaultTerminalOutputDevice(ServiceProvider serviceProvider)
=> new(
serviceProvider.GetTestApplicationCancellationTokenSource(),
serviceProvider.GetConsole(),
=> new(serviceProvider.GetConsole(),

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 44 in src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs#L44 

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs(44,16): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=> new(serviceProvider.GetConsole(),
=> new(
serviceProvider.GetConsole(),

serviceProvider.GetTestApplicationModuleInfo(),
serviceProvider.GetTestHostControllerInfo(),
serviceProvider.GetAsyncMonitorFactory().Create(),
Expand Down
5 changes: 2 additions & 3 deletions src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ internal sealed partial class TerminalOutputDevice : IHotReloadPlatformOutputDev
private const string TESTINGPLATFORM_CONSOLEOUTPUTDEVICE_SKIP_BANNER = nameof(TESTINGPLATFORM_CONSOLEOUTPUTDEVICE_SKIP_BANNER);
#pragma warning restore SA1310 // Field names should not contain underscore

private readonly ITestApplicationCancellationTokenSource _testApplicationCancellationTokenSource;
private readonly IConsole _console;
private readonly ITestApplicationModuleInfo _testApplicationModuleInfo;
private readonly ITestHostControllerInfo _testHostControllerInfo;
Expand Down Expand Up @@ -64,13 +63,13 @@ internal sealed partial class TerminalOutputDevice : IHotReloadPlatformOutputDev
private bool _isServerMode;
private ILogger? _logger;

public TerminalOutputDevice(ITestApplicationCancellationTokenSource testApplicationCancellationTokenSource, IConsole console,
public TerminalOutputDevice(
IConsole console,
ITestApplicationModuleInfo testApplicationModuleInfo, ITestHostControllerInfo testHostControllerInfo, IAsyncMonitor asyncMonitor,
IRuntimeFeature runtimeFeature, IEnvironment environment, IProcessHandler process, IPlatformInformation platformInformation,
ICommandLineOptions commandLineOptions, IFileLoggerInformation? fileLoggerInformation, ILoggerFactory loggerFactory, IClock clock,
IStopPoliciesService policiesService)
{
_testApplicationCancellationTokenSource = testApplicationCancellationTokenSource;
_console = console;
_testApplicationModuleInfo = testApplicationModuleInfo;
_testHostControllerInfo = testHostControllerInfo;
Expand Down
Loading