Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UsingMSTestSdk property #4754

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add UsingMSTestSdk property #4754

merged 1 commit into from
Jan 22, 2025

Conversation

aelij
Copy link
Member

@aelij aelij commented Jan 22, 2025

The Microsoft.NET.Sdk sets a UsingMicrosoftNETSdk property which allows other imported files to rely on it, for example in Directory.Build.{props, targets}. This PR adds a similar UsingMSTestSdk for the MSTest SDK.

Evangelink
Evangelink reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It seems to make sense. @baronfel @rainersigwald could you please confirm?

baronfel
baronfel approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this pattern is fine. Folks have asked MSBuild itself to create the property in a consistent way, but we don't have a design for it

@Evangelink Evangelink merged commit 630e6fc into microsoft:main Jan 22, 2025
7 of 9 checks passed
@Evangelink
Copy link
Member

Thanks @aelij

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@baronfel baronfel baronfel approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelij @Evangelink @baronfel