Add support for horizontal mouse wheel events #19248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
aymanbagabas
force-pushed
the
support-hwheel
branch
5 times, most recently
from
e326ed1 to
90a82d4
Compare
lhecker
reviewed
Aug 19, 2025
This adds support for horizontal mouse wheel events (WM_MOUSEHWHEEL). With this change, applications running in the terminal can now receive and respond to horizontal scroll inputs from the mouse/trackpad. Fixes: microsoft#19245
aymanbagabas
force-pushed
the
support-hwheel
branch
from
90a82d4 to
b9cfb5a
Compare
aymanbagabas
force-pushed
the
support-hwheel
branch
from
b9cfb5a to
cc95e48
Compare
DHowett
reviewed
Sep 10, 2025
| case WM_MOUSEHWHEEL: | ||
| if (delta > 0) | ||
| { | ||
| return MakeOutput(_keyMap.at(VK_LEFT)); |
There was a problem hiding this comment.
Okay, that's really cool actually. alternate scroll does this?
DHowett
reviewed
Sep 10, 2025
| winrt::Microsoft::Terminal::Core::Point wheelDelta{ 0, static_cast<int32_t>(HIWORD(wparam)) }; | ||
| if (message == WM_MOUSEHWHEEL) | ||
| { | ||
| wheelDelta.X = wheelDelta.Y; |
There was a problem hiding this comment.
if you want to get too clever, you can probably std::swap(wheelDelta.X, wheelDelta.Y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds support for horizontal mouse wheel events (WM_MOUSEHWHEEL). With this change, applications running in the terminal can now receive and respond to horizontal scroll inputs from the mouse/trackpad.
References and Relevant Issues
Closes #19245
Closes #10329
Validation Steps Performed
Tested terminal applications that receive horizontal mouse wheel events.
PR Checklist