Setting to set pane highlight active, inactive and broadcast color #18953

Techypanda · 2025-05-27T07:02:54Z

Summary of the Pull Request

This commit adds a new setting in which you can configure the active highlight color of panes as well as inactive and broadcast. This will only happen if configured otherwise uses the default as suggested by #3061

References and Relevant Issues

#3061

Detailed Description of the Pull Request / Additional comments

When modifying the settings you can now set pane key to have the following properties:

"activeBorderColor"
"inactiveBorderColor"
"broadcastBorderColor"
This allows for more configuration of the windows terminal

Validation Steps Performed

Built Locally, Ran Locally and configured a profile with the following theme:

"themes": 
[
    {
        "name": "Under Construction",
        "tab": {
            "background": "#FFFF00FF",
            "iconStyle": "default",
            "showCloseButton": "always",
            "unfocusedBackground": "#88440088"
        },
        "tabRow": {
            "background": "#FF8800FF",
            "unfocusedBackground": "#202020FF"
        },
        "window": {
            "applicationTheme": "light",
            "experimental.rainbowFrame": false,
            "frame": null,
            "unfocusedFrame": null,
            "useMica": true
        },
        "pane": {
            "activeBorderColor": "#13A10E",
            "inactiveBorderColor": "#61D6D6"
        }
    }
]

PR Checklist

Closes Add a setting to manually set the Pane highlight color #3061
Tests added/passed (None added, can't see how to unit test this but happy to add/dive deeper)
Documentation updated
- If checked, please file a pull request on our docs repo and link it here: #xxx
Schema updated (if necessary) -> I have modified to the best of my knowledge

Techypanda · 2025-05-27T07:05:57Z

@microsoft-github-policy-service agree

carlos-zamora

Downloaded the branch and played around with it for a bit. Looks and feels great!

Blocking mainly for the issue where "accent" and "terminalBackground" aren't handled properly.

Also don't forget to update the docs repo please

Thanks!

src/cascadia/TerminalApp/TerminalPage.cpp

Techypanda · 2025-06-04T04:56:28Z

Downloaded the branch and played around with it for a bit. Looks and feels great!

Blocking mainly for the issue where "accent" and "terminalBackground" aren't handled properly.

Fixed in latest push can you retest when available? Thanks

Also don't forget to update the docs repo please

Can update the docs repo, will raise a PR there

…roadcast color

carlos-zamora

Setting all the pane's border colors to "accent" still doesn't work:

            "pane":
            {
                "activeBorderColor": "accent",
                "inactiveBorderColor": "accent",
                "broadcastBorderColor": "accent"
            },

carlos-zamora · 2025-06-10T22:53:48Z

src/cascadia/TerminalApp/TerminalPage.cpp

+        const auto paneActiveBorderColor = theme.Pane() ? theme.Pane().ActiveBorderColor() : nullptr;
+        const auto paneInactiveBorderColor = theme.Pane() ? theme.Pane().InactiveBorderColor() : nullptr;
+        const auto broadcastBorderColor = theme.Pane() ? theme.Pane().BroadcastBorderColor() : nullptr;
+        const auto requestedTheme{ theme.RequestedTheme() };

        {
-            _updatePaneResources(requestedTheme);
+            _updatePaneResources(requestedTheme, paneActiveBorderColor, paneInactiveBorderColor, broadcastBorderColor);


I think you don't actually need the variables. In MTSMSettings.h, the last parameter in the macro is nullptr, so if the setting isn't defined, the getter should already retrieve nullptr. You should be able to pass theme.Pane().ActiveBorderColor() and the other ones directly into _updatePaneResources.

tested this by removing the pane key from my json and reloading: crashed as theme.Pane() was null; I need the ternary or it goes nullptr.ActiveBorderColor() which crashes it (i could be wrong).

Will try a way that im thinking to clean this up but i dont believe i can pass this directly as you suggest unless im mistaken

src/cascadia/TerminalApp/TerminalPage.cpp

Techypanda · 2025-06-16T11:38:09Z

Found the bug with accent, it was because i wasnt picking accent key sorted that and all 3 being set to accent seems to work
Also found the bug with terminalbackground, swapped to use Evaluate with backgroundBrush as TerminalTab uses (also fed this in and raised where this is used outside the updatePane method).

carlos-zamora

Tested the branch out and cycled between combinations of...

toggling broadcast input mode
setting one of the pane.XBorderColor properties to accent vs an rgb value

Looks and feels great! Same with the code! Thank you so much for doing this! 😊

Sorry for the delay 😅. I was OOF on vacation.

carlos-zamora · 2025-07-16T18:31:07Z

/azp run

azure-pipelines · 2025-07-16T18:31:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Techypanda · 2025-07-17T00:48:20Z

Documentation PR - MicrosoftDocs/terminal#872

This commit adds a new setting in which you can configure the active highlight color of panes aswell as inactive and broadcast.

Techypanda · 2025-07-17T00:55:21Z

Rebased & Ran Invoke-CodeFormat as i believe the failures were due to this

lhecker · 2025-07-21T12:08:47Z

@Techypanda If possible, please avoid force-pushing. Now we have to review the PR from scratch. 🙂

carlos-zamora · 2025-07-21T22:37:53Z

/azp run

azure-pipelines · 2025-07-21T22:38:02Z

Azure Pipelines successfully started running 1 pipeline(s).

DHowett

(Sorry - i'm not blocking this one because of you, I just wanted to make sure I got a chance to review it :))

This comment has been minimized.

Sign in to view

Techypanda force-pushed the pane-highlight-setting branch 2 times, most recently from 97b01e4 to b660e34 Compare May 29, 2025 03:59

carlos-zamora requested changes Jun 3, 2025

View reviewed changes

microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 3, 2025

Techypanda force-pushed the pane-highlight-setting branch from b660e34 to ce1ba03 Compare June 4, 2025 04:53

Techypanda requested a review from carlos-zamora June 4, 2025 04:56

carlos-zamora added a commit that referenced this pull request Jun 10, 2025

PRE-MERGE #18953 Setting to set pane highlight active, inactive and b…

533e48d

…roadcast color

carlos-zamora requested changes Jun 11, 2025

View reviewed changes

microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 11, 2025

Techypanda force-pushed the pane-highlight-setting branch from ce1ba03 to f8202e2 Compare June 16, 2025 10:41

Techypanda marked this pull request as draft June 16, 2025 10:55

Techypanda force-pushed the pane-highlight-setting branch from f8202e2 to 320267c Compare June 16, 2025 11:34

Techypanda marked this pull request as ready for review June 16, 2025 11:37

Techypanda requested a review from carlos-zamora June 16, 2025 11:38

carlos-zamora approved these changes Jul 16, 2025

View reviewed changes

Techypanda mentioned this pull request Jul 17, 2025

Add documentation for pane theming MicrosoftDocs/terminal#872

Open

Setting to set pane highlight active, inactive and broadcast color

7573799

This commit adds a new setting in which you can configure the active highlight color of panes aswell as inactive and broadcast.

Techypanda force-pushed the pane-highlight-setting branch from 320267c to 7573799 Compare July 17, 2025 00:54

Techypanda requested a review from carlos-zamora July 17, 2025 00:55

DHowett requested changes Jul 21, 2025

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 21, 2025

microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jul 28, 2025

microsoft-github-policy-service bot closed this Aug 5, 2025

carlos-zamora reopened this Aug 5, 2025

microsoft-github-policy-service bot removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 5, 2025

microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 12, 2025

carlos-zamora removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Aug 12, 2025

carlos-zamora assigned DHowett Aug 12, 2025

Setting to set pane highlight active, inactive and broadcast color #18953

Are you sure you want to change the base?

Setting to set pane highlight active, inactive and broadcast color #18953

Uh oh!

Conversation

Techypanda commented May 27, 2025

Summary of the Pull Request

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

Uh oh!

This comment has been minimized.

Techypanda commented May 27, 2025

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Techypanda commented Jun 4, 2025

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-zamora Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Techypanda Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Techypanda commented Jun 16, 2025

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-zamora commented Jul 16, 2025

Uh oh!

azure-pipelines bot commented Jul 16, 2025

Uh oh!

Techypanda commented Jul 17, 2025

Uh oh!

Techypanda commented Jul 17, 2025

Uh oh!

lhecker commented Jul 21, 2025

Uh oh!

carlos-zamora commented Jul 21, 2025

Uh oh!

azure-pipelines bot commented Jul 21, 2025

Uh oh!

DHowett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!