Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parsing of responses from the AI #18220

Open
wants to merge 11 commits into
base: feature/llm
Choose a base branch
from
Open

Improve parsing of responses from the AI #18220

wants to merge 11 commits into from
+100 −157

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

Instead of manually parsing out code blocks from the response we receive, leverage the markdown to xaml parsing introduced in #17585

Validation Steps Performed

Responses are parsed as expected.

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@PankajBhojwani PankajBhojwani mentioned this pull request Nov 19, 2024
Closed
4 tasks
@PankajBhojwani PankajBhojwani changed the title just in case Improve parsing of responses from the AI Nov 19, 2024
@PankajBhojwani
Copy link
Contributor Author

Screenshot for the new look (clicking the 'play' button sends the input to the shell):

image

lhecker
lhecker approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 questions + what Dustin wrote.

src/cascadia/QueryExtension/ExtensionPalette.cpp Outdated Show resolved Hide resolved
src/cascadia/QueryExtension/ExtensionPalette.cpp Show resolved Hide resolved
src/cascadia/QueryExtension/ExtensionPalette.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett left review comments

@lhecker lhecker lhecker approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PankajBhojwani @DHowett @lhecker