Test CodeQL workflow #224
Test CodeQL workflow #224
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a parameterless AddClient() convenience method to the AppBuilder class, following the established pattern of providing default implementations for builder methods (similar to the existing AddLogger() method).
Key Changes:
- Adds a new
AddClient()overload that creates a defaultHttpClientinstance without requiring parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public AppBuilder AddClient() | ||
| { | ||
| _options.Client = new Common.Http.HttpClient(); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
The newly added parameterless AddClient() method lacks test coverage. Since the repository has comprehensive testing for the Microsoft.Teams.Apps namespace (see Tests/Microsoft.Teams.Apps.Tests/AppTests.cs), this new method should include unit tests to verify:
- That it correctly creates a default
HttpClientinstance - That it properly sets
_options.Client - That it returns the
AppBuilderinstance for method chaining
Consider adding tests similar to the existing tests in AppTests.cs.
|
Resolved the code ql issue. Turns out the previous "default" setup configuration had to be deleted for this to work. |
1 participant
No description provided.