Skip to content

Conversation

@ShanmathiMayuramKrithivasan
Copy link
Collaborator

Problem

App.Send() cannot send targeted messages because it builds ConversationReference, dropping the required User field that specifies the recipient id for targeted messages.

Fix

  • Set ConversationReference.User = activity.Recipient when isTargeted=true in App.Send()
  • This ensures the sender plugin can properly set the outgoing activity's recipient
  • Maintains backward compatibility for non-targeted messages (User remains null)

Copilot AI review requested due to automatic review settings December 8, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the App.Send() method to properly support targeted messages by ensuring the ConversationReference.User field is populated with the recipient information when sending targeted messages. Previously, this field was always null, preventing sender plugins from correctly routing messages to specific recipients.

Key Changes:

  • Added validation to ensure activity.Recipient is set when isTargeted=true
  • Set ConversationReference.User to activity.Recipient for targeted messages, enabling sender plugins to properly route the message
  • Maintained backward compatibility by keeping User as null for non-targeted messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ShanmathiMayuramKrithivasan ShanmathiMayuramKrithivasan merged commit 5c40750 into microsoft:main Dec 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants