-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sai/dac options map table #1542
Conversation
…move displayname property
… need to update SC code base too
Tests are failing because if needs new DacFx nuget to get the names, but they all are passing on local(as i used the DacFx new dlls). DacFx PR is out and once its merged will updated the Nuget version here. |
can you please split this into 2 PRs?
|
since FriendlyName is being used in Map Table, cannot split it out of maptable, but may be I can try splitting include objects types related changes from map table, I want top use this PR as is for my development and will generate 2 new PRs. Thanks |
Separated these changes into 2 PRs:
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
This PR fixes