[heft-node-test-plugin] Introduce heft-node-test-plugin#5511
Draft
[heft-node-test-plugin] Introduce heft-node-test-plugin#5511
Conversation
dmichon-msft
reviewed
Jan 2, 2026
| ); | ||
|
|
||
| let config: INodeTestConfiguration = {}; | ||
| if (await FileSystem.existsAsync(configPath)) { |
Contributor
There was a problem hiding this comment.
Read and handle missing file instead, please.
| taskSession.logger.terminal.writeDebugLine(`Executing: node ${args.join(' ')}`); | ||
|
|
||
| const child = child_process.spawn('node', args, { | ||
| stdio: ['inherit', 'inherit', 'inherit'], |
Contributor
There was a problem hiding this comment.
Typically we prefer to pipe so that we can label the output and associate it with the plugin.
| reject(new Error(`Failed to spawn Node.js test process: ${error.message}`)); | ||
| }); | ||
|
|
||
| child.on('exit', (code, signal) => { |
Contributor
There was a problem hiding this comment.
We may wish to use close instead to ensure that all output has been processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
How it was tested
Impacted documentation