[rush] Fix an issue where the rush-serve-plugin port parameter was allowed to be a string.#5104
Merged
iclanton merged 1 commit intomicrosoft:mainfrom Feb 11, 2025
Merged
Conversation
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
dmichon-msft
approved these changes
Feb 11, 2025
Contributor
dmichon-msft
left a comment
dmichon-msft
left a comment
There was a problem hiding this comment.
This had been because integer was not previously a valid parameterKind in command-line.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where the port parameter in
@rushstack/rush-serve-pluginwas allowed to be a string parameter.How it was tested
Ran locally.