Use os.availableParallelism() instead of os.cpus().length#5091
Merged
dmichon-msft merged 2 commits intomicrosoft:mainfrom Jan 30, 2025
Merged
Use os.availableParallelism() instead of os.cpus().length#5091dmichon-msft merged 2 commits intomicrosoft:mainfrom
dmichon-msft merged 2 commits intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
TheLarkInn,
apostolisms,
iclanton and
octogonz
as code owners
D4N14L
approved these changes
Jan 30, 2025
D4N14L
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prefer using
os.availableParallelism()toos.cpus().lengthThe former API was introduced in NodeJS 18 and performs a lot less work than the latter.
Details
In Node 22,
os.cpus()opens several files to read info about each CPU on every invocation.How it was tested
Build, since this API is used to determine parallelism of Rush, as well as various unit tests.
Impacted documentation
Only a few method comments where the default comes from this method.