[rush-lib] Add --timeline parameter for all phased commands#5082
Merged
iclanton merged 2 commits intomicrosoft:mainfrom Jan 22, 2025
Merged
[rush-lib] Add --timeline parameter for all phased commands#5082iclanton merged 2 commits intomicrosoft:mainfrom
iclanton merged 2 commits intomicrosoft:mainfrom
Conversation
elliot-nelson
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
iclanton
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the
--timelineoption even if a phased command does not support parallelism.Details
Today, the
--timelineoption is only available on the command line if a phased command supports parallelism.However, this option is useful in many cases even if there is no parallelism -- the histogram can help identify visually which projects are bottlenecks in the execution flow, and the summary at the end is helpful for showing the breakdown of total time spent in the different phases across all projects.
How it was tested
--timelineoption was availableImpacted documentation