Skip to content

[eslint-bulk] Fix caching during eslintrc lookup #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmichon-msft merged 1 commit into from
Jan 7, 2025
Merged

[eslint-bulk] Fix caching during eslintrc lookup #5065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@rushstack/eslint-patch/eslint-cache-bug_2025-01-07-00-34.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/eslint-patch",
"comment": "Fix a performance issue when locating \".eslint-bulk-suppressions.json\".",
"type": "patch"
}
],
"packageName": "@rushstack/eslint-patch"
}
4 changes: 3 additions & 1 deletion eslint/eslint-patch/src/eslint-bulk-suppressions/bulk-suppressions-patch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ function findEslintrcFolderPathForNormalizedFileAbsolutePath(normalizedFilePath:
) {
const cachedEslintrcFolderPath: string | undefined = eslintrcPathByFileOrFolderPath.get(currentFolder);
if (cachedEslintrcFolderPath) {
return cachedEslintrcFolderPath;
// Need to cache this result into the intermediate paths
eslintrcFolderPath = cachedEslintrcFolderPath;
break;
}

pathsToCache.push(currentFolder);
Expand Down
Loading