fix: allow injected dependencies when subspaces are disabled #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aramis Sennyey <[email protected]>
aramissennyeydd
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
Signed-off-by: Aramis Sennyey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original question in Zulip: https://rushstack.zulipchat.com/#narrow/channel/262513-general/topic/Injected.20Dependencies.20and.20Subspaces/near/490904453
I'm trying to enable injected dependencies and was getting some confusing error messages (and a lack of
repo-state.jsonchanges) that indicated something wasn't updating as it should have. Looks like injected dependencies were gated at some point between subspaces and I can't see a great reason why they should be.Details
Remove check for having subspaces enabled when using injected dependencies.
How it was tested
Tested in our repository that the repo-state file had changes after running
rush updateand that subsequent runs were cached.Impacted documentation