Skip to content

Commit 44b9ff2

Browse files
rebase fixes
Signed-off-by: Aramis Sennyey <[email protected]>
1 parent d8cc307 commit 44b9ff2

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

build-tests/rush-redis-cobuild-plugin-integration-test/sandbox/sharded-repo/projects/e/config/rush-project.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,13 @@
44
{
55
"operationName": "_phase:build",
66
"outputFolderNames": ["dist"],
7-
"allowCobuildOrchestration": true,
8-
"disableBuildCacheForOperation": true,
97
"sharding": {
108
"count": 75
119
}
1210
},
1311
{
1412
"operationName": "_phase:build:shard",
15-
"weight": 10,
16-
"allowCobuildOrchestration": true
13+
"weight": 10
1714
}
1815
]
1916
}

libraries/rush-lib/src/logic/operations/OperationExecutionRecord.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
323323
beforeResult: (record: OperationExecutionRecord) => Promise<void>;
324324
onResult: (record: OperationExecutionRecord) => Promise<void> | void;
325325
}): Promise<void> {
326-
if (!this.isTerminal) {
327-
this.stopwatch.reset();
326+
if (this.stopwatch.startTime === undefined) {
327+
this.stopwatch.start();
328328
}
329329
this.status = OperationStatus.Executing;
330330

@@ -349,8 +349,6 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
349349
// We may need to clean up and finalize resources (_operationMetadataManager for example needs to be saved by CacheableOperationPlugin)
350350
await beforeResult(this);
351351
if (this.isTerminal) {
352-
this._collatedWriter?.close();
353-
this.stdioSummarizer.close();
354352
this.stopwatch.stop();
355353
if (
356354
!this.executedOnThisAgent &&
@@ -367,6 +365,11 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
367365
}
368366
}
369367
}
368+
await onResult(this);
369+
if (this.isTerminal) {
370+
this._collatedWriter?.close();
371+
this.stdioSummarizer.close();
372+
}
370373
}
371374
}
372375
}

0 commit comments

Comments
 (0)