Skip to content

Commit d8cc307

Browse files
fix build
Signed-off-by: Aramis Sennyey <[email protected]>
1 parent 1871fad commit d8cc307

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

common/reviews/api/rush-lib.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,9 +582,9 @@ export interface _INpmOptionsJson extends IPackageManagerOptionsJsonBase {
582582
export interface IOperationExecutionResult {
583583
readonly cobuildRunnerId: string | undefined;
584584
readonly error: Error | undefined;
585+
readonly executedOnThisAgent: boolean;
585586
readonly logFilePaths: ILogFilePaths | undefined;
586587
readonly metadataFolderPath: string | undefined;
587-
readonly executedOnThisAgent: boolean;
588588
readonly nonCachedDurationMs: number | undefined;
589589
readonly operation: Operation;
590590
readonly silent: boolean;

libraries/rush-lib/src/logic/operations/OperationExecutionRecord.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ import type { RushConfigurationProject } from '../../api/RushConfigurationProjec
2525
import { CollatedTerminalProvider } from '../../utilities/CollatedTerminalProvider';
2626
import type { IOperationExecutionResult } from './IOperationExecutionResult';
2727
import type { CobuildConfiguration } from '../../api/CobuildConfiguration';
28+
import {
29+
getProjectLogFilePaths,
30+
type ILogFilePaths,
31+
initializeProjectLogFilesAsync
32+
} from './ProjectLogWritable';
2833

2934
export interface IOperationExecutionRecordContext {
3035
streamCollator: StreamCollator;
@@ -334,8 +339,8 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
334339
this.status = this.operation.enabled
335340
? await this.runner.executeAsync(this)
336341
: this.runner.isNoOp
337-
? OperationStatus.NoOp
338-
: OperationStatus.Skipped;
342+
? OperationStatus.NoOp
343+
: OperationStatus.Skipped;
339344
}
340345
} catch (error) {
341346
this.status = OperationStatus.Failure;
@@ -362,12 +367,6 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
362367
}
363368
}
364369
}
365-
// Delegate global state reporting
366-
await onResult(this);
367-
if (this.status !== OperationStatus.RemoteExecuting) {
368-
this._collatedWriter?.close();
369-
this.stdioSummarizer.close();
370-
}
371370
}
372371
}
373372
}

0 commit comments

Comments
 (0)