-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): add network perf tests for Retina #772
base: main
Are you sure you want to change the base?
Conversation
- Added new performance tests for iperf throughput (TCP and UDP) - Metrics include CPU Utilization Host, CPU Utilization Remote, Max RTT, Mean RTT, Min RTT, Retransmits, and Total Throughput This commit introduces new performance tests to measure iperf throughput under various conditions for the Retina project. Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a test on uksouth
and getting this
--------------------------------------------------------------------------------
RESPONSE 400: 400 Bad Request
ERROR CODE: ErrCode_InsufficientVCPUQuota
--------------------------------------------------------------------------------
{
"code": "ErrCode_InsufficientVCPUQuota",
"details": null,
"message": "Insufficient regional vcpu quota left for location uksouth. left regional vcpu quota 20, requested quota 36",
"subcode": ""
}
--------------------------------------------------------------------------------
Test: TestPerfRetina
I also run the test in westus2
, and that was not an issue, but I got the following:
2024/09/27 17:48:52 DaemonSet is not ready: kube-system/retina-agent. 0 out of 3 expected pods are ready
2024/09/27 17:48:54 DaemonSet is not ready: kube-system/retina-agent. 0 out of 3 expected pods are ready
2024/09/27 17:48:56 DaemonSet is not ready: kube-system/retina-agent. 0 out of 3 expected pods are ready
2024/09/27 17:48:58 DaemonSet is not ready: kube-system/retina-agent. 0 out of 3 expected pods are ready
2024/09/27 17:49:00 DaemonSet is not ready: kube-system/retina-agent. 0 out of 3 expected pods are ready
2024/09/27 17:49:02 Error received when checking status of resource retina-svc. Error: 'client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline', Resource details: 'Resource: "/v1, Resource=services", GroupVersionKind: "/v1, Kind=Service"
Name: "retina-svc", Namespace: "kube-system"'
2024/09/27 17:49:02 Retryable error? true
2024/09/27 17:49:02 Retrying as current number of retries 0 less than max number of retries 30
runner.go:27:
Error Trace: /home/srodi/src/retina/test/e2e/framework/types/runner.go:27
/home/srodi/src/retina/test/e2e/retina_perf_test.go:65
Error: Received unexpected error:
did not expect error from step InstallHelmChart but got error: failed to install chart: context deadline exceeded
Test: TestPerfRetina
DeleteResourceGroup setting stored value for parameter [SubscriptionID] set as [......-.....-....-....-.........]
DeleteResourceGroup setting stored value for parameter [ResourceGroupName] set as [srodi-e2e-netobs-1727452628]
DeleteResourceGroup setting stored value for parameter [Location] set as [westus2]
#################### DeleteResourceGroup ################################################################
2024/09/27 17:49:02 deleting resource group "srodi-e2e-netobs-1727452628"...
2024/09/27 17:49:05 resource group "srodi-e2e-netobs-1727452628" deleted successfully
--- FAIL: TestPerfRetina (3269.87s)
FYI @ritwikranjan
Signed-off-by: Ritwik Ranjan <[email protected]>
@ritwikranjan I just got another fail on insufficient quota, this time for runner.go:27:
Error Trace: /home/srodi/src/retina/test/e2e/framework/types/runner.go:27
/home/srodi/src/retina/test/e2e/retina_perf_test.go:52
Error: Received unexpected error:
did not expect error from step CreateNPMCluster but got error: failed to finish the create cluster request: PUT https://management.azure.com/subscriptions/....-....-....-....-.........../resourceGroups/srodi-e2e-netobs-1727879517/providers/Microsoft.ContainerService/managedClusters/srodi-e2e-netobs-1727879517
--------------------------------------------------------------------------------
RESPONSE 400: 400 Bad Request
ERROR CODE: ErrCode_InsufficientVCPUQuota
--------------------------------------------------------------------------------
{
"code": "ErrCode_InsufficientVCPUQuota",
"details": null,
"message": "Insufficient vcpu quota requested 32, remaining 0 for family standardDSv2Family for region centralus.",
"subcode": ""
}
--------------------------------------------------------------------------------
Test: TestE2EPerfRetina
--- FAIL: TestE2EPerfRetina (26.22s)
FAIL
FAIL command-line-arguments 26.239s
FAIL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritwikranjan I am getting the following error while running the test based on the most recent commit
runner.go:27:
Error Trace: /home/srodi/src/retina/test/e2e/framework/types/runner.go:27
/home/srodi/src/retina/test/e2e/retina_perf_test.go:63
Error: Received unexpected error:
did not expect error from step GetNetworkPerformanceMeasures but got error: failed to get network performance measures: failed to execute tests: error getting CSV data from orchestrator pod: error reading logs from pod netperf-orch-59dsc: the server rejected our request for an unknown reason (get pods netperf-orch-59dsc)
Test: TestE2EPerfRetina
Signed-off-by: Ritwik Ranjan <[email protected]>
Will help with identifying issue #655 |
Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
Signed-off-by: Ritwik Ranjan <[email protected]>
Description
This pull request introduces several updates related to performance testing, dependency upgrades, and workflow enhancements. The most important changes include the addition of a new performance measurement workflow, updates to dependencies in
go.mod
, and modifications to the e2e test setup and execution.Performance Testing Enhancements:
.github/workflows/perf.yaml
).test/e2e/retina_perf_test.go
,test/e2e/scenarios/perf/get-network-performance-measures.go
). [1] [2]Workflow and Configuration Changes:
.github/workflows/e2e.yaml
).azure-cli
feature to the devcontainer configuration (.devcontainer/devcontainer.json
).Documentation:
test/e2e/README.md
).These changes collectively enhance the testing infrastructure, improve dependency management, and provide better documentation for performance testing.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.