Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): avoid loading legacy autolinking script #2291

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(android): avoid loading legacy autolinking script #2291

merged 1 commit into from
Oct 22, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 22, 2024 •
edited
Loading

Description

Resolves #2206.
Resolves #2285.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

Windows CI should pass.

Also verify that 0.74 still works:

npm run set-react-version 0.74
yarn
cd example/android
yarn android

# In a separate terminal
yarn start

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Oct 22, 2024
@tido64 tido64 force-pushed the tido/android/re-enable-ci branch 9 times, most recently from 62ecf91 to 2ad9dbf Compare October 22, 2024 16:51
@tido64 tido64 changed the title ci(android): re-enable builds/tests on Windows fix(android): avoid loading legacy autolinking script Oct 22, 2024
@tido64 tido64 force-pushed the tido/android/re-enable-ci branch 3 times, most recently from a2e3deb to 7e683d2 Compare October 22, 2024 17:00
@tido64 tido64 marked this pull request as ready for review October 22, 2024 17:13
@tido64 tido64 requested a review from JasonVMo as a code owner October 22, 2024 17:13
@tido64 tido64 requested review from Saadnajmi and removed request for JasonVMo October 22, 2024 17:13
@tido64 tido64 merged commit afa75aa into trunk Oct 22, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/re-enable-ci branch October 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

windows: grandle Releasing lock on daemon addresses registry Android: Re-enable Android builds on Windows
2 participants
@tido64 @Saadnajmi