Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate build/run commands to @rnx-kit/cli #2266

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

chore: migrate build/run commands to @rnx-kit/cli #2266

wants to merge 1 commit into from

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 1, 2024

Description

Migrate build/run commands to @rnx-kit/cli

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

This only affects the example app. CI should pass.

Saadnajmi
Saadnajmi reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth somehow testing that RNTA works with both CLIs?

@tido64
Copy link
Member Author

tido64 commented Oct 2, 2024

Is it worth somehow testing that RNTA works with both CLIs?

Yeah, this is mostly to test @rnx-kit/cli in more scenarios. I think for this to land, we would have to set up a matrix.

@tido64 tido64 mentioned this pull request Oct 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi left review comments

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo will be requested when the pull request is marked ready for review JasonVMo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi