-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): make it clear that configure-test-app
performs a reset
#2262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one question here is how often this is run. If this is run all the time then I would warn when we do modify the config. If it is only when configuring a project then the existing behavior makes sense. I'm assuming that this runs as part of project configuration.
On second thought, I think you're right. The warning should only appear when you explicitly run |
react-native.config.js
if it may be configuredconfigure-test-app
performs a reset
Consider adding very specific warnings for |
I've changed the wording to include "template". I don't think we want to specifically call out |
Description
Change the messaging to make it clear that we're doing factory reset.
Resolves #2260.
Platforms affected
Test plan
Expected output: