Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix run-windows not launching apps built with New Arch #2256

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 23, 2024

Description

run-windows fails to launch apps built with New Arch because artifacts are output relative to the .wapproj under node_modules/.generated/windows/Win32/bin, but the command expects them to be under the solution directory.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example
yarn install-windows-test-app --use-fabric
yarn windows

@github-actions github-actions bot added the platform: Windows This affects Windows label Sep 23, 2024
@tido64
Copy link
Member Author

tido64 commented Sep 23, 2024

cc @Yajur-Grover

windows/Win32/pch.h Outdated Show resolved Hide resolved
windows/Win32/pch.h Show resolved Hide resolved
@tido64 tido64 changed the title fix(windows): fix run-windows not launching app built with New Arch fix(windows): fix run-windows not launching apps built with New Arch Sep 24, 2024
@Yajur-Grover
Copy link
Contributor

Yajur-Grover commented Sep 24, 2024

Was able to build and deploy the example app following the steps in the test plan above. Hit with the following error, which I hit previously using RNTA on async-storage with New Architecture:
image

AFAIK, this error is unrelated to the RNTA repo, and is caused by the layoutDirection logic that should be resolved once this PR is merged in.

@tido64 tido64 merged commit 415fd32 into trunk Sep 24, 2024
27 checks passed
@tido64 tido64 deleted the tido/windows/fix-run-windows branch September 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants