remove dependency to canvas
#2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billti
approved these changes
Jan 15, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ScottCarda-MS
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only using the
canvaspackage for snapshot tests to mock out usage of the canvas element in the product code.The product doesn't need to use a Canvas element to estimate text width. Since we have a limited set of characters in gate names anyway, estimating with a small utility works just as well (and is probably more performant too since it doesn't do actual rendering)
The difference between the old method and the new method is a few pixels at most in all of the samples and snapshots I checked. There are no visually noticeable changes.