Make stubs installable from github #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 7, 2024
Comment on lines
+9
to
+22
| # Allow these stubs to be installed from GitHub | ||
| # We need an explicit mapping instead of just | ||
| # [tool.setuptools] | ||
| # package-dir = {"" = "stubs"} | ||
| # because the folder names don't all match "*-stubs" | ||
| # see https://github.com/microsoft/python-type-stubs/issues/315 | ||
| [tool.setuptools.package-dir] | ||
| # See README.md as to why matplotlib is not included | ||
| "networkx-stubs" = "stubs/networkx" | ||
| "skimage-stubs" = "stubs/skimage" | ||
| "sklearn-stubs" = "stubs/sklearn" | ||
| "sympy-stubs" = "stubs/sympy-stubs" | ||
| "transformers-stubs" = "stubs/transformers-stubs" | ||
| "vispy-stubs" = "stubs/vispy" |
There was a problem hiding this comment.
With #315 , this would become
Suggested change
| # Allow these stubs to be installed from GitHub | |
| # We need an explicit mapping instead of just | |
| # [tool.setuptools] | |
| # package-dir = {"" = "stubs"} | |
| # because the folder names don't all match "*-stubs" | |
| # see https://github.com/microsoft/python-type-stubs/issues/315 | |
| [tool.setuptools.package-dir] | |
| # See README.md as to why matplotlib is not included | |
| "networkx-stubs" = "stubs/networkx" | |
| "skimage-stubs" = "stubs/skimage" | |
| "sklearn-stubs" = "stubs/sklearn" | |
| "sympy-stubs" = "stubs/sympy-stubs" | |
| "transformers-stubs" = "stubs/transformers-stubs" | |
| "vispy-stubs" = "stubs/vispy" | |
| # Allow these stubs to be installed from GitHub | |
| [tool.setuptools] | |
| package-dir = {"" = "stubs"} |
But then it would include matplotlib, maybe we do want to keep it explicit ?
debonte
approved these changes
Nov 7, 2024
|
Very cool! Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to close #264