Fix all reportMissingImports #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 7, 2024
| def set_units(self, u: None | timezone | float | BasicUnit) -> None: ... | ||
| def get_units(self) -> None | timezone | float | BasicUnit: ... | ||
| def set_units(self, u) -> None: ... | ||
| def get_units(self): ... |
There was a problem hiding this comment.
This should be generic, rather than adding random third-party types that may be used (or maybe this comes from some old matplotlib stuff?). Anyway, matplotlib now provides its own types.
There was a problem hiding this comment.
Yeah, I believe we kept these stubs for users that are still using matplotlib 3.7 and earlier.
Avasam
commented
Nov 7, 2024
| @@ -5,6 +5,7 @@ pyright | |||
|
|
|||
| # Typed libraries and stubs | |||
| matplotlib>=3.8 | |||
| pandas-stubs | |||
There was a problem hiding this comment.
pandas is imported by matplotlib, networkx, sklearn, skimage and vispy
Avasam
force-pushed
the
Fix-all-reportMissingImports
branch
from
e45e60a to
7bb3d5b
Compare
debonte
approved these changes
Nov 7, 2024
Avasam
force-pushed
the
Fix-all-reportMissingImports
branch
3 times, most recently
from
3715ee2 to
60cecea
Compare
Avasam
force-pushed
the
Fix-all-reportMissingImports
branch
from
60cecea to
97b7a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.