fix: set default Host header in httpRequest options #37115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"2 flaky46620 passed, 805 skipped Merge workflow run. |
|
Is there an issue this fixes? Could you please start filing a GitHub issue + ideally add a test for it? |
In Windows 11, when I set the system environment variable HTTP_PROXY=http://127.0.0.1:10809/, when accessing HTTP URLs through the HTTP proxy, the host gets changed to the proxy's IP and port, for example: 127.0.0.1:10809, but the actual host should be the target URL(http://127.0.0.1:53041/). |
|
Please create a GitHub issue with a reproduction + add a test to this PR. Without that we can't review changes, thanks! |
|
Closing as per above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.