fix: do not crash component tests on stale cached files #37070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
agg23
reviewed
Aug 18, 2025
|
|
||
| await test.step('add a "leftover" (no longer existing component and its test file) to the cache and run the test', async () => { | ||
|
|
||
| metainfo.components.push({ |
There was a problem hiding this comment.
This should be an end to end test, and should test the entire flow of building the cache, deleting a component, then running the test and finding that it still works. Don't mutate the metainfo.json manually.
shairez
force-pushed
the
pr-fix-ct-cache-deleted-tests
branch
from
48f9248 to
f818161
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
reviewed
Aug 18, 2025
| componentRegistry.set(c.id, c); | ||
| for (const c of oldComponents.values()) { | ||
| // Only add old components if their source test file still exists | ||
| if (fs.existsSync(c.filename)) |
There was a problem hiding this comment.
Does it have to be sync? If not, prefer fs.promises.stat
shairez
force-pushed
the
pr-fix-ct-cache-deleted-tests
branch
2 times, most recently
from
705c7e8 to
5693a80
Compare
shairez
force-pushed
the
pr-fix-ct-cache-deleted-tests
branch
from
5693a80 to
37e3d37
Compare
Test results for "tests 1"11 flaky46621 passed, 801 skipped Merge workflow run. |
|
Added the requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big quality of life improvement for component testers
Fixes #37069