feat(test info): Add possibility to use test file name without extenson in snapshotPathTemplate #33420
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
…on in snapshotPathTemplate
SishaMafonov
force-pushed
the
feat/snapshot-path-without-extension
branch
from
8b64b1a
to
5eb044d
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 flaky36783 passed, 630 skipped Merge workflow run. |
yury-s
reviewed
Nov 5, 2024
| @@ -454,6 +454,7 @@ export class TestInfoImpl implements TestInfo { | |||
| .replace(/\{(.)?projectName\}/g, projectNamePathSegment ? '$1' + projectNamePathSegment : '') | |||
| .replace(/\{(.)?testName\}/g, '$1' + this._fsSanitizedTestName()) | |||
| .replace(/\{(.)?testFileName\}/g, '$1' + parsedRelativeTestFilePath.base) | |||
| .replace(/\{(.)?testFileNameWithoutExtension\}/g, '$1' + parsedRelativeTestFilePath.base.replace('.spec', '').replace('.ts', '')) | |||
There was a problem hiding this comment.
There is also at least *.spec.js, *.spec.tsx, *.spec.jsx, and same with .test. in the name.
| @@ -79,6 +79,9 @@ test('tokens should expand property', async ({ runInlineTest }, testInfo) => { | |||
| }, { | |||
| name: 'testFileName', | |||
| snapshotPathTemplate: '{testFileName}', | |||
| }, { | |||
| name: 'testFileNameWithoutExtension', | |||
| snapshotPathTemplate: '{testFileNameWithoutExtension}', | |||
There was a problem hiding this comment.
The actual expects need to be extended too to cover various use cases of the new token.
|
@SishaMafonov Do you plan to update this PR and get it merged, or should I close it? |
I apologize for the delay. I am planning to update it shortly. I apologize for inconvenience. |
|
IMO this is a use case of #33098, proving it has interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment there is no possibility to get test file name without the extension for
snapshotPathTemplate. Please refer to #24171Our stakeholders requested to have path to snapshots without test file extension because it is confusing for them. The best place to achieve that is PW framework repo rather than custom fixtures in the project.
What was done
snapshotPathTemplateto cut out extension for the test file namesnapshotPathTemplateTesting