Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: vendor 'proxy' dependency #29370

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

mxschmitt
Copy link
Member

Fixes #28701

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Test results for "tests 1"

1 failed
❌ [playwright-test] › watch.spec.ts:564:5 › should run CT on changed deps

4 flaky ⚠️ [chromium] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26539 passed, 615 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the tests worth copying the dependency, I'd probably just disable them for now. Up to you.

@mxschmitt mxschmitt merged commit 57d841f into microsoft:main Feb 5, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal] look into 'should proxy local network request' that will EPIPE
2 participants