chore: running tests should create workspace-settings #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
src/extension.ts
Outdated
| @@ -129,6 +129,7 @@ export class Extension implements RunHooks { | |||
| } | |||
|
|
|||
| async onWillRunTests(config: TestConfig, debug: boolean) { | |||
| this._models.onWillRunTests(); | |||
There was a problem hiding this comment.
This one is a little funny because embedder (extension) notifies model collection that a model called the embedder and notified it about the runTests event. I would call collection.saveSettings right where the model runs tests instead to save on the indirection.
There was a problem hiding this comment.
It is! Didn't feel like I could just remove the private, so I added some indirection. But it looks like TestModel also calls TestModelCollection#_modelUpdated, so they trust one another. Made the change!
pavelfeldman
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store settings like activated projects in
pw.workspace-settings. But we only write to it if it's modified, which means that users who never change anything about them don't get their settings stored. If we ever change the default settings, this means their workflows + muscle memory will be broken. Not good!To prevent that from happening, this PR makes us
saveSettings()before every test run. It also adds some tests to cover that.