chore: reuse test run request #566
Merged
+58
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Dec 11, 2024
| this._completedSteps.clear(); | ||
| this._executionLinesChanged(); | ||
| const include = request.include; | ||
|
|
||
| // Create a test run that potentially includes all the test items. | ||
| // This allows running setup tests that are outside of the scope of the | ||
| // selected test items. | ||
| const rootItems: vscodeTypes.TestItem[] = []; |
There was a problem hiding this comment.
This can be removed since microsoft/vscode#213182 has been landed upstream.
There was a problem hiding this comment.
You mean remove the comment? I think the code is used.
mxschmitt
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright#30815
Closes #564