Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terminal link highlighter inside box #546

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mxschmitt
Copy link
Member

Sometimes we print commands inside a box:

    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browser:               ║
    ║                                                                         ║
    ║     npx playwright install chromium-headless-shell                      ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝

this was then not working correctly with the link highlighter which included the right box character. The new regex won't do that anymore.

@mxschmitt mxschmitt merged commit 6284d07 into microsoft:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants