Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double fills while debugging #398

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: double fills while debugging #398

merged 1 commit into from
Dec 6, 2023

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Dec 1, 2023

This regressed in 59f828d.

Fixes microsoft/playwright#28437.

@pavelfeldman
Copy link
Member

Can we keep the highlight?

@mxschmitt
Copy link
Member Author

Can we keep the highlight?

I tested highlight of await page.fill('[placeholder="What needs to be done?"]', TODO_ITEMS[0]); in step mode (breakpoint) and highlight mode (move mouse over it). Seems to work in both cases.

@mxschmitt mxschmitt merged commit 6fb94e4 into main Dec 6, 2023
6 checks passed
@mxschmitt mxschmitt deleted the fix-double-fills branch December 6, 2023 21:08
@nbaldzhiev
Copy link

Hi @mxschmitt @pavelfeldman , how can I track what version this will be included in? I have that bug as well in VS Code Version: 1.84.2 (Universal) Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e on MacOS 13.4.1 (22F82), Playwright is at 1.37.1 and I am currently debugging in Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] .fill() duplicating text in debug mode (v1.40)
3 participants