openhcl: refactor shared pool to general purpose page pool #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
yupavlen-ms
reviewed
Nov 7, 2024
smalis-msft
reviewed
Nov 7, 2024
mattkur
reviewed
Nov 8, 2024
mattkur
reviewed
Nov 8, 2024
chris-oo
force-pushed
the
page-pool-refactor
branch
from
be6a2d7
to
3259bdc
Compare
chris-oo
force-pushed
the
page-pool-refactor
branch
from
131b81d
to
149ae0b
Compare
chris-oo
commented
Nov 15, 2024
chris-oo
force-pushed
the
page-pool-refactor
branch
from
96e6fdc
to
488801c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the shared visibility pool to a more general purpose page pool. This is in preparation for additional changes to support save restore, and private allocations.
Add a new
new_private_poolmethod to support future private memory page pools.Add additional tracking of allocations with device_ids and device names, which will be used for save restore. This can also help track current allocations. Update
NvmeManagerto hand out per-device allocators, which better helps allocations per device.In the future, it would be good to additionally update the VfioDmaBuffer trait to have additional tagging, as today all allocations are just tagged as "vfio dma" which isn't very helpful when inspecting.