[webgpu] Enable profiling for graph capture #27058
Open
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaofeihan1
reviewed
Jan 19, 2026
| } | ||
| context_.Replay(captured_commands_, *graph_buffer_mgr_); | ||
| if (profiler_->Enabled()) { | ||
| context_.CollectProfilingData(profiler_->Events()); |
Contributor
There was a problem hiding this comment.
As you know, I deleted the parameter inCollectProfilingData(), so this needs special attention here.
Contributor
There was a problem hiding this comment.
When replaying, OnRunStart and OnRunEnd will be not called? It seems it is difficult for considering run-level profiling for replaying here
Contributor
Author
There was a problem hiding this comment.
I will update this pr if #26846 is merged first.
When replaying, OnRunStart and OnRunEnd will be not called? It seems it is difficult for considering run-level profiling for replaying here
Maybe we can extend Status ReplayGraph(int graph_annotation_id) to Status ReplayGraph(int graph_annotation_id, bool run_profiling = false) to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context