Fix incorrect warning suppression in projects using precompiled headers on Windows #27039
+70
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expectedly suppressed in the unit test projects that use precompiled headers. e.g. C4834 was suppressed so there was no warning for the nodiscard Status return value not being checked in a Windows build. Generates a warning on other platforms. Update a few tests to resolve warnings that now get triggered.
yuslepukhin
reviewed
Jan 17, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ctWarningSuppressionInWindowsBuild
Fix QNN test
…ctWarningSuppressionInWindowsBuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable cmake prologue in pch file which results in warnings being unexpectedly suppressed in the unit test projects that use precompiled headers.
e.g. C4834 was suppressed so there was no warning for the nodiscard Status return value not being checked in a Windows build. Generates a warning on other platforms.
Update a few tests to resolve warnings that now get triggered.
Motivation and Context
Warnings causing build failures for non-Windows CIs that should have been generated for Windows builds.