Fix the bug in setting _fallback_providers
#27018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byounguk Lee <[email protected]>
nimdrak
changed the title
_fallback_providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug regarding how
_fallback_providersis set. With this change, when setting providers to["TensorrtExecutionProvider", "CUDAExecutionProvider"], _fallback_providers will correctly resolve to["CUDAExecutionProvider", "CPUExecutionProvider"].Motivation and Context
Fixes #27006
When setting providers to
["TensorrtExecutionProvider", "CUDAExecutionProvider"], _fallback_providers is expected to be["CUDAExecutionProvider", "CPUExecutionProvider"]. However, currently it results in["CPUExecutionProvider"].This issue originates from the else statement logic within
NvTensorRTRTXExecutionProvider. It appears the original intention was to prioritizeNvTensorRTRTXExecutionProvider, but it inadvertently caused this bug.This PR fixes the issue while preserving the original design intention.