Skip to content

Conversation

@eserscor
Copy link
Contributor

Description

Fix GPU JAR testing

Motivation and Context

Testing JAR for GPU was missing libcustom_library.so on Linux.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes GPU JAR testing on Linux by ensuring the custom operations library is properly packaged in the testing JAR.

Changes:

  • Updated GPU package configuration to include libcustom_op_library.so in the testing JAR
  • Added debug output to the test script to verify test directory contents
  • Improved shell script quoting for the classpath parameter

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/ci_build/github/windows/jar_packaging.py Changed archive_lib flag from False to True for GPU Linux x64 to include libcustom_op_library.so in testing JAR
tools/ci_build/github/linux/java_linux_final_test.sh Added ls command for debugging and quoted the --scan-classpath parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eserscor eserscor marked this pull request as ready for review January 16, 2026 17:57
@tianleiwu tianleiwu changed the title Dev/erscor/2026/1/10 jar testing Fix GPU JAR testing on Linux Jan 17, 2026
mavenVersionOption: 'Default'

- task: Bash@3
displayName: 'Run Java Tests on Linux/macOS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change name since macOS is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants