[MIGraphX EP] Proof of concept: Implement OrtExternalResourceImporter for D3D12-HIP interop #27001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for D3D12-HIP interop Add experimental implementation of OrtExternalResourceImporter interface for MIGraphX EP to enable zero-copy import of D3D12 shared resources on Windows via HIP Runtime APIs. This proof of concept demonstrates: **Memory Import** - Import D3D12 committed resources (ORT_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_RESOURCE) - Import D3D12 heaps (ORT_EXTERNAL_MEMORY_HANDLE_TYPE_D3D12_HEAP) - Map imported resources using hipExternalMemoryGetMappedBuffer - Create ORT tensors backed by imported device memory for zero-copy access **Synchronization** - Import D3D12 timeline fences as HIP external semaphores - Implement wait/signal operations on HIP streams - Enable GPU-GPU synchronization between D3D12 and HIP workloads **Infrastructure** - MigraphxExternalMemoryHandle: Wraps hipExternalMemory_t with mapped pointers - MigraphxExternalSemaphoreHandle: Wraps hipExternalSemaphore_t for D3D12 fences - MigraphxSyncStreamImpl: Wraps hipStream_t for OrtSyncStream interface - Factory integration via CreateExternalResourceImporterForDeviceImpl **Key Files** - onnxruntime/core/providers/migraphx/migraphx_external_resource_importer.h - onnxruntime/core/providers/migraphx/migraphx_external_resource_importer.cc - onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc (updated) This enables scenarios like DirectML → MIGraphX model chaining without CPU round-trips, improving performance for hybrid GPU workloads. Windows-only implementation (guarded by #ifdef _WIN32).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,551 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
Check warning
Code scanning / lintrunner
CLANGFORMAT/format Warning
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+297
to
+298
| impl.device_id_, OrtMemTypeDefault, | ||
| &memory_info); |
Contributor
There was a problem hiding this comment.
Suggested change
| impl.device_id_, OrtMemTypeDefault, | |
| &memory_info); | |
| impl.device_id_, OrtMemTypeDefault, | |
| &memory_info); |
Comment on lines
+454
to
+456
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental implementation of OrtExternalResourceImporter interface for MIGraphX EP to enable zero-copy import of D3D12 shared resources on Windows via HIP Runtime APIs.
This proof of concept demonstrates:
Memory Import
Synchronization
Infrastructure
Key Files
This enables scenarios like DirectML → MIGraphX model chaining without CPU round-trips, improving performance for hybrid GPU workloads.