Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN] Support SkipSimplifiedLayerNormalization op #23151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WebNN] Support SkipSimplifiedLayerNormalization op #23151

wants to merge 3 commits into from

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Dec 19, 2024

The algorithm of SkipSimplifiedLayerNormalization is quite similar to the SimplifiedLayerNormalization, only different is SkipSimplifiedLayerNormalization provides an additional output used for calculating the sum of the input, skip and bias (if it exits).

BTW, fix a bug in SimplifiedLayerNormalization, adding bias if it exits.

@Honry
Copy link
Contributor Author

Honry commented Dec 19, 2024

@fdwr, @guschmue, PTAL, thanks!

@Honry
[WebNN] Support SkipSimplifiedLayerNormalization op
c8d9efc 
The algorithm of SkipSimplifiedLayerNormalization is quite
similar to the SimplifiedLayerNormalization, only different
is SkipSimplifiedLayerNormalization provides an additional
output used for caculating the sum of the input, skip and
bias (if it exits).

BTW, fix a bug in SimplifiedLayerNormalization, adding bias
if it exits.
@Honry Honry force-pushed the skip-simplified-layernorm branch from e6780a0 to c8d9efc Compare December 19, 2024 12:48
guschmue
guschmue previously approved these changes Dec 19, 2024
View reviewed changes
@guschmue guschmue added the ep:WebNN WebNN execution provider label Dec 19, 2024
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@guschmue
Copy link
Contributor

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

fdwr
fdwr previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc Outdated Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/normalization_op_builder.cc Outdated Show resolved Hide resolved
@fdwr
Copy link
Contributor

fdwr commented Dec 19, 2024 •
edited
Loading

ONNX Runtime Web CI Pipeline ...
npm error code E409
npm error 409 Conflict - GET https://registry.npmjs.org/shiki/-/shiki-0.14.7.tgz
source

Possible infrastructure issue. Restarting.

Passed now.

@Honry Honry dismissed stale reviews from fdwr and guschmue via 49801bd December 20, 2024 01:48
@Honry
Copy link
Contributor Author

Honry commented Dec 20, 2024

@fdwr, thanks for your comments, fixed in new commit, PTAL again.

fdwr
fdwr reviewed Dec 21, 2024
View reviewed changes
js/web/docs/webnn-operators.md
@@ -89,7 +89,7 @@ operators and the supported opset domain/versions in **WebNN EP** by ONNX Runtim
| ScatterElements | ai.onnx(11-12, 13-15, 16-17, 18+) | scatterElements | ✗ | ✓ | Only supports 'reduction' == 'none' |
| ScatterND | ai.onnx(11-12, 13-15, 16-17, 18+) | scatterND | ✗ | ✓ | Only supports 'reduction' == 'none' |
| Shape | ai.onnx(7-12, 13-14, 15-18, 19-20, 21+) | slice | ✓ | ✓ | |
| SimplifiedLayerNormalization | com.microsoft(1+) | pow, reduceMean, add, sqrt, div, mul | ✓ | ✓ | |
| SimplifiedLayerNormalization | ai.onnx(1+) | pow, reduceMean, add, sqrt, div, mul | ✓ | ✓ | |
Copy link
Contributor

@fdwr fdwr Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an active ONNX CR for this? Otherwise SLN is Microsoft-specific (not an ONNX operator). https://github.com/onnx/onnx/blob/main/docs/Operators.md

fdwr
fdwr reviewed Dec 21, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the markdown change. 🤔

@fdwr
Copy link
Contributor

fdwr commented Dec 21, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 21, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 21, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 21, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr left review comments

@guschmue guschmue guschmue left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @guschmue @fdwr