Added functionality to choose dml adapter by luid #1041
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution. Can you please add a test/tests for the new functionality? |
|
This should be reviewed by the DML team. |
DavitGrigoryan132
force-pushed
the
directml_luid_device_selection
branch
from
8ceb706
to
691d9e3
Compare
src/dml/dml_helpers.cpp
Outdated
Comment on lines
57
to
67
| ComPtr<IDXGIAdapter1> adapter; | ||
| for (uint32_t adapter_index = 0; dxgi_factory->EnumAdapters1(adapter_index, &adapter) != DXGI_ERROR_NOT_FOUND; adapter_index++) { | ||
| // We can't assume the ordering of hardware and software adapters, so keep looping. This path should only execute on Windows 10 | ||
| // version 1709 or earlier; IDD (e.g. remote desktop) adapters do not exist when taking this code path. | ||
| if (IsSoftwareAdapter(adapter.Get())) { | ||
| continue; | ||
| } | ||
|
|
||
| // Make sure that we are able to create the device | ||
| ComPtr<ID3D12Device> d3d12_device; | ||
| THROW_IF_FAILED(D3D12CreateDevice(adapter.Get(), D3D_FEATURE_LEVEL_11_0, IID_PPV_ARGS(&d3d12_device))); |
There was a problem hiding this comment.
This enumeration code is the same as the code below. I think It's better to have a single else block, and to only have an if (device_luid) when it's time to actually push it to the adapter_infos vector.
DavitGrigoryan132
force-pushed
the
directml_luid_device_selection
branch
from
691d9e3
to
329214d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds functionality to allow users to specify a "DML" (DirectML) execution provider device adapter by providing the adapter's LUID (Locally Unique Identifier). Previously, the system would automatically select the most performant adapter by default. With this enhancement, users can now select a specific adapter by passing the luid_high_part and luid_low_part options, giving them greater control over device selection.
Key Changes:
Added support for selecting a DML execution provider device adapter using luid_high_part and luid_low_part.
Default behavior remains the same, choosing the most performant adapter unless these options are specified.
Motivation: This update provides more flexibility for users needing to target specific adapters, enhancing customizability in environments with multiple available adapters.