Added Java Bindings for Adapters API #1030
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyline75489
commented
Nov 4, 2024
skottmckay
reviewed
Nov 5, 2024
| * @param adapterName A unique user supplied adapter identifier. | ||
| * @throws GenAIException If the call to the GenAI native API fails. | ||
| */ | ||
| public void loadAdapters(String adapterFilePath, String adapterName) throws GenAIException { |
There was a problem hiding this comment.
Is there an API that allows passing in bytes for the adapter so we can read from the app's assets and not need to copy to the app's filesDir so it has a valid path?
There was a problem hiding this comment.
I'll have to ask @baijumeswani do we have that? I don't think so. Reading from bytes seems a reasonable option.
This reverts commit f33874f.
|
I just realize that the Java tests have not been actually run for a very long time and a lots of things are broken...this is gonna take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal work item: https://task.ms/aii/52363