Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use intersection for DateTime, DateTimeOffset type definitions #373

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: use intersection for DateTime, DateTimeOffset type definitions #373

merged 1 commit into from
Sep 3, 2024

Conversation

Waleed-KH
Copy link
Contributor

According to the docs, DateTime & DateTimeOffset get mapped to JS Date value by adding either a kind or offset property to a regular Date object. For more accurate type definitions, it should use intersection (&) instead of union (|)

@Waleed-KH
Copy link
Contributor Author

@microsoft-github-policy-service agree

jasongin
jasongin approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jasongin jasongin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasongin jasongin merged commit 1e6eea5 into microsoft:main Sep 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waleed-KH @jasongin