Strip JS end-comment tokens when generating typedefs (#333)

microsoft · Jul 22, 2024 · baaafdc · baaafdc
1 parent e2e8576
commit baaafdc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/NodeApi.Generator/TypeDefinitionsGenerator.cs b/src/NodeApi.Generator/TypeDefinitionsGenerator.cs
@@ -2196,8 +2196,14 @@ private static string FormatDocText(XNode? node)
             }
         }
 
-        return s_newlineRegex.Replace(
-            (node?.ToString() ?? string.Empty).Replace("\r", "").Trim(), " ");
+        string text = node?.ToString() ?? string.Empty;
+        text = s_newlineRegex.Replace(text.Replace("\r", ""), " ");
+
+        // Remove end-comment tokens to prevent them from ending the JS doc-comments.
+        text = text.Replace("*/", string.Empty);
+
+        text = text.Trim();
+        return text;
     }
 
     private static string FormatDocMethodName(MethodInfo method)

diff --git a/test/TypeDefsGeneratorTests.cs b/test/TypeDefsGeneratorTests.cs
@@ -156,7 +156,7 @@ export enum TestEnum {
             """.ReplaceLineEndings(),
         GenerateTypeDefinition(typeof(TestEnum), new Dictionary<string, string>
         {
-            ["T:TestEnum"] = "enum",
+            ["T:TestEnum"] = "enum */",
             ["F:TestEnum.Zero"] = "zero",
             ["F:TestEnum.One"] = "one",
         }));