Skip to content

Commit

Permalink
Re-enable code signing (#421)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoroz authored Jan 17, 2025
1 parent a150c53 commit 50061dd
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions .ado/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ resources:

variables:
- name: DisableSigning # Disable signing while we have no access to certificate
value: true
value: false
- name: DisableOsxArm64CodeQL
value: true # Temporary disable CodeQL for OSX ARM64 until it is fixed by CodeQL team.

Expand Down Expand Up @@ -310,13 +310,6 @@ extends:
submodules: false
lfs: false

# .Net 6.0 is required for the code signing task
- task: UseDotNet@2
displayName: Install .Net 6.0.x
inputs:
packageType: sdk
version: 6.0.x

- task: UseDotNet@2
displayName: Install .NET SDK using global.json
inputs:
Expand Down Expand Up @@ -354,11 +347,6 @@ extends:
- script: echo $(TargetRuntimeList)
displayName: Show RID list

- task: DeleteFiles@1 # Code signing utility requires net6.0 runtime
displayName: Delete global.json for CodeSign
inputs:
Contents: global.json

- ${{ if ne(variables.DisableSigning, true) }}:
- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
displayName: CodeSign Binaries
Expand All @@ -372,8 +360,8 @@ extends:
FolderPath: $(Build.SourcesDirectory)/out/bin/Release
# Recursively finds files matching these patterns:
Pattern: |
NodeApi/aot/win-x64/publish/Microsoft.JavaScript.NodeApi.node
**/Microsoft.JavaScript.NodeApi.dll
**/win-x64/publish/Microsoft.JavaScript.NodeApi.node
**/Microsoft.JavaScript.NodeApi.DotNetHost.dll
**/Microsoft.JavaScript.NodeApi.Generator.dll
**/Microsoft.JavaScript.NodeApi.Generator.exe
Expand Down

0 comments on commit 50061dd

Please sign in to comment.