Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MockHiiLib, MockShellLib, MockHiiDatabase protocol #1248

Open
wants to merge 3 commits into
base: dev/202405
Choose a base branch
from

Conversation

v-bhavanisu
Copy link
Contributor

Description

Added MockHiiLib, MockShellLib, MockHiiDatabase protocol to be used by GoogleTests

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Consumed these mocks in Googletests of other repos and build successful

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch. labels Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.53%. Comparing base (a40e166) to head (15d443d).
Report is 1 commits behind head on dev/202405.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405    #1248      +/-   ##
==============================================
- Coverage        1.60%    1.53%   -0.07%     
==============================================
  Files            1377     1377              
  Lines          359246   358364     -882     
  Branches         5524     3785    -1739     
==============================================
- Hits             5760     5498     -262     
+ Misses         353379   352778     -601     
+ Partials          107       88      -19     
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.08% <ø> (-0.52%) ⬇️
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-bhavanisu
Copy link
Contributor Author

Hi @apop5 and @VivianNK - Please help to review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants