Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Createa Mock for PciRootBridgeIoProtocol, MockPciPlatformProtocol & add mock function under MockUefiBootServiceTableLib #1213

Conversation

v-boscochen
Copy link
Contributor

@v-boscochen v-boscochen commented Nov 8, 2024

Description

Add mock functions under MockUefiBootServiceTableLib , and Create Mock for PciRootBridgeIoProtocol

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch. labels Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (4abc700) to head (45e5b98).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1213   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1377     1377           
  Lines          359246   359246           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353379   353379           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.60% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-boscochen
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch from 0384dbd to dfa8b62 Compare November 11, 2024 03:31
@v-boscochen
Copy link
Contributor Author

v-boscochen commented Nov 11, 2024

Hi @VivianNK, @apop5, @os-d
Would you kindly help review this change?
Thanks,
Bosco

@v-boscochen v-boscochen changed the title Task2133227: Createa Mock for PciRootBridgeIoProtocol & and mock function under MockUefiBootServiceTableLib Createa Mock for PciRootBridgeIoProtocol & add mock function under MockUefiBootServiceTableLib Nov 11, 2024
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch 2 times, most recently from dafaf18 to 038c4c4 Compare November 19, 2024 08:16
@v-boscochen v-boscochen changed the title Createa Mock for PciRootBridgeIoProtocol & add mock function under MockUefiBootServiceTableLib Createa Mock for PciRootBridgeIoProtocol, MockPciPlatformProtocol & add mock function under MockUefiBootServiceTableLib Nov 19, 2024
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch 2 times, most recently from 397611e to 06c8625 Compare November 22, 2024 02:20
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch 2 times, most recently from 3c4cb19 to 6c31485 Compare December 6, 2024 05:00
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch from 83e40f1 to 0102403 Compare December 11, 2024 09:49
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch from 0102403 to f7fa5a1 Compare December 12, 2024 01:44
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch from f7fa5a1 to 78b4f27 Compare December 16, 2024 05:05
@apop5 apop5 enabled auto-merge (squash) December 18, 2024 02:11
@apop5 apop5 disabled auto-merge December 18, 2024 03:25
v-boscochen and others added 7 commits December 18, 2024 12:01
…ib/MockUefiBootServicesTableLib.cpp

Co-authored-by: Oliver Smith-Denny <[email protected]>
Signed-off-by: v-boscochen <[email protected]>
…ib/MockUefiBootServicesTableLib.cpp

Co-authored-by: Oliver Smith-Denny <[email protected]>
Signed-off-by: v-boscochen <[email protected]>
…esTableLib.h

Co-authored-by: Oliver Smith-Denny <[email protected]>
Signed-off-by: v-boscochen <[email protected]>
@v-boscochen v-boscochen force-pushed the usrs/Bosco/Task2133227_gmock_for_PciRootBridgeIoProtocol&MockUefiBootServiceTableLib branch from b47e732 to ec709b0 Compare December 18, 2024 04:01
…otBridgeIoProtocol&MockUefiBootServiceTableLib
@apop5 apop5 merged commit 33473bd into microsoft:dev/202405 Dec 18, 2024
31 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 18, 2024
…dd mock function under MockUefiBootServiceTableLib (#1213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants