UefiCpuPkg: Fixing page table handling for non-present pages. [202405] #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1081 +/- ##
================================================
Coverage ? 4.77%
================================================
Files ? 133
Lines ? 26097
Branches ? 535
================================================
Hits ? 1245
Misses ? 24828
Partials ? 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Jul 30, 2024
makubacki
reviewed
Jul 30, 2024
apop5
force-pushed
the
personal/apop5/fixpagetablenonpresent
branch
from
c6fb9d5 to
32f8b07
Compare
os-d
approved these changes
Jul 31, 2024
|
The old PR link could be removed from the commit subject. This commit will link to this PR which will explain it was a cherry-pick. Going directly to the original PR via that link might be confusing. |
makubacki
approved these changes
Jul 31, 2024
…t pages. This change will add logic to populate the address and propagate bits for the non-present pages. Without this change, the issue can be seen as when a smaller page is marked present from a big non-present page, the remainder of the non-present pages will return `EFI_UNSUPPORTED` when using get attributes function though protocols like CPU arch.
apop5
force-pushed
the
personal/apop5/fixpagetablenonpresent
branch
from
32f8b07 to
c7f6228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will add logic to populate the address and propagate bits for the non-present pages.
Without this change, the issue can be seen as when a smaller page is marked present from a big non-present page, the remainder of the non-present pages will return
EFI_UNSUPPORTEDwhen using get attributes function though protocols like CPU arch.4ca95f2
flow, or firmware?
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This was tested on QEMU Q35 platform and booted to OS. N/A
Integration Instructions
N/A