Skip to content

Commit

Permalink
BaseTools: Disable Second DLINK step for WHOLEARCHIVE
Browse files Browse the repository at this point in the history
Project Mu does not use WHOLEARCHIVE, due to issues in silicon
partner code when it is enabled. In order to support WHOLEARCHIVE,
edk2 added a second dlink step in the build rules to get the
benefit of identifying duplicate symbols without needing the
space expansion. This is an extra linking step for each module
and so does increase build time. Without WHOLEARCHIVE, this is
an unneeded step on Mu, so it is disabled here.
  • Loading branch information
os-d committed Dec 11, 2024
1 parent 7161cac commit 2848772
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion BaseTools/Conf/build_rule.template
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@
$(DEBUG_DIR)(+)$(MODULE_NAME).dll

<Command.MSFT, Command.INTEL>
"$(DLINK)" /OUT:${dst} $(DLINK_FLAGS) $(DLINK2_FLAGS) $(DLINK_SPATH) @$(STATIC_LIBRARY_FILES_LIST)
# "$(DLINK)" /OUT:${dst} $(DLINK_FLAGS) $(DLINK2_FLAGS) $(DLINK_SPATH) @$(STATIC_LIBRARY_FILES_LIST) MU_CHANGE: Drop Extra DLINK step for WHOLEARCHIVE
"$(DLINK)" /OUT:${dst} $(DLINK_FLAGS) $(DLINK_SPATH) @$(STATIC_LIBRARY_FILES_LIST)

<Command.CLANGPDB>
Expand Down

0 comments on commit 2848772

Please sign in to comment.