Issue#2550 - Fixed getGeneratedKeys functionality for execute API

[machavan]

Description:

The execute API for INSERT was not reading off the explicit TDS_DONE token that actually contains the update count returned by the server. As a result, it was not able to correctly report back the update count for getUpdateCount and also the subsequent resultsets on getMoreResults.

Note that this works correctly for excecuteUpdate API.

Testing:

• All existing tests pass
• Introduced a number of tests testing various combinations of execute/executeUpdate API, INSERT/UPDATE/DELETE/MERGE DML operations, followed by explicit SELECT statement or getGeneratedKeys call.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 51.33%. Comparing base (2a3d372) to head (978d8f3).

Files with missing lines	Patch %	Lines
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java	50.00%	4 Missing and 3 partials ⚠️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2554      +/-   ##
============================================
+ Coverage     51.11%   51.33%   +0.21%     
- Complexity     3924     3952      +28     
============================================
  Files           147      147              
  Lines         33505    33512       +7     
  Branches       5614     5616       +2     
============================================
+ Hits          17126    17202      +76     
+ Misses        13961    13874      -87     
- Partials       2418     2436      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tkyc]

Internal tests pass

[martinoconnor]

Suggestion: may also wish to verify that the execute API works with SET NOCOUNT ON;

[machavan]

Suggestion: may also wish to verify that the execute API works with SET NOCOUNT ON;

Yes, verified with execute API and added a new test case